Add session storage clustering support #3555
Conversation
woutslakhorst
force-pushed
the
feature/3553/clustered_memstore
branch
from
586e3c9 to
88cdf94
Compare
woutslakhorst
force-pushed
the
feature/3553/clustered_memstore
branch
from
88cdf94 to
39aa9aa
Compare
woutslakhorst
requested review from
reinkrul,
gerardsn and
stevenvegt
as code owners
woutslakhorst
changed the title
| ########## | ||
|
|
||
| With the introduction of a SQL database and separate session storage, clustering with HA is now possible. | ||
| Clustering is currently limited to nodes that have the ``did:nuts`` method disabled. |
There was a problem hiding this comment.
maybe state what NOT to do (use default on-disk/in-memory stores for private keys and stuff)?
e2e-tests/clustering/redis/node-A/presentationexchangemapping.json
Outdated
Show resolved
Hide resolved
|
Do we need/have something in diagnostics on the session store? |
there's no |
|
The |
| results["session"] = core.Health{ | ||
| Status: core.HealthStatusUp, | ||
| } | ||
| err := e.sessionDatabase.GetStore(defaultSessionDataTTL, "healthcheck").Get("does_not_exist", nil) |
| // StringOrBytes is a type that can be either a string or a byte slice | ||
| // used for generic type constraints | ||
| type StringOrBytes interface { | ||
| ~string | ~[]byte |
|
|
||
| // NewMemcachedSessionDatabase creates a new MemcachedSessionDatabase using an initialized memcache.Client. | ||
| func NewMemcachedSessionDatabase(client *memcache.Client) *MemcachedSessionDatabase { | ||
| memcachedStore := memcachestore.NewMemcache(client, store.WithExpiration(defaultSessionDataTTL)) |
There was a problem hiding this comment.
Shouldn't we use the same value for access token lifetime? Or at least, the token lifetime shouldn't be longer than this default. Having 2 seeminly unrelated constants (but secretly relating) seems rather dangerous?
There was a problem hiding this comment.
I added a comment. Memcached requires a default setting. We override this value when writing with the TTL of the store.
closes #3553